Re: [PATCH net-next] ieee802154: 6lowpan: remove unnecessary comparison

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello.

On 08.05.20 05:52, Yang Yingliang wrote:
The type of dispatch is u8 which is always '<=' 0xff, so the
dispatch <= 0xff is always true, we can remove this comparison.

Reported-by: Hulk Robot <hulkci@xxxxxxxxxx>
Signed-off-by: Yang Yingliang <yangyingliang@xxxxxxxxxx>
---
  net/ieee802154/6lowpan/rx.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/ieee802154/6lowpan/rx.c b/net/ieee802154/6lowpan/rx.c
index ee17938..b34d050 100644
--- a/net/ieee802154/6lowpan/rx.c
+++ b/net/ieee802154/6lowpan/rx.c
@@ -240,7 +240,7 @@ static inline bool lowpan_is_reserved(u8 dispatch)
  	return ((dispatch >= 0x44 && dispatch <= 0x4F) ||
  		(dispatch >= 0x51 && dispatch <= 0x5F) ||
  		(dispatch >= 0xc8 && dispatch <= 0xdf) ||
-		(dispatch >= 0xe8 && dispatch <= 0xff));
+		dispatch >= 0xe8);
  }
/* lowpan_rx_h_check checks on generic 6LoWPAN requirements


This looks good to me. Thanks for fixing this.

Signed-off-by: Stefan Schmidt <stefan@xxxxxxxxxxxxxxxxxx>

Dave, can you apply this directly to your net tree? I have no other ieee802154 fixes pending to fill a pull request.

regards
Stefan Schmidt



[Index of Archives]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux