On Tue, 3 Mar 2020 16:39:55 +0100 Stefan Schmidt wrote: > On 03.03.20 06:05, Jakub Kicinski wrote: > > Add missing attribute type validation for IEEE802154_ATTR_DEV_TYPE > > to the netlink policy. > > > > Fixes: 90c049b2c6ae ("ieee802154: interface type to be added") > > Signed-off-by: Jakub Kicinski <kuba@xxxxxxxxxx> > > diff --git a/net/ieee802154/nl_policy.c b/net/ieee802154/nl_policy.c > > index 824e7e84014c..0672b2f01586 100644 > > --- a/net/ieee802154/nl_policy.c > > +++ b/net/ieee802154/nl_policy.c > > @@ -27,6 +27,7 @@ const struct nla_policy ieee802154_policy[IEEE802154_ATTR_MAX + 1] = { > > [IEEE802154_ATTR_BAT_EXT] = { .type = NLA_U8, }, > > [IEEE802154_ATTR_COORD_REALIGN] = { .type = NLA_U8, }, > > [IEEE802154_ATTR_PAGE] = { .type = NLA_U8, }, > > + [IEEE802154_ATTR_DEV_TYPE] = { .type = NLA_U8, }, > > [IEEE802154_ATTR_COORD_SHORT_ADDR] = { .type = NLA_U16, }, > > [IEEE802154_ATTR_COORD_HW_ADDR] = { .type = NLA_HW_ADDR, }, > > [IEEE802154_ATTR_COORD_PAN_ID] = { .type = NLA_U16, }, > > > > The reason to split this off from the patch before is to have the Fixes > tag differently to point to its origin? Yup, plus they should hopefully be in chronological order to avoid conflicts :) > Might be a bit to much work for this little subsystem, but you did it > already, so: > > Acked-by: Stefan Schmidt <stefan@xxxxxxxxxxxxxxxxxx> Thanks!