From: Jian-Hong Pan <starnight@xxxxxxxxxxxx>
Date: Tue, 6 Nov 2018 00:55:40 +0800
> +static inline struct lrw_mac_cb * mac_cb(struct sk_buff *skb)
"mac_cb()" is pretty generic for a name, and leads to namespace pollution,
please use lrw_mac_cb() or similar.
> +static inline struct dgram_sock *
> +dgram_sk(const struct sock *sk)
> +{
> + return container_of(sk, struct dgram_sock, sk);
> +}
> +
> +static inline struct net_device *
> +lrw_get_dev_by_addr(struct net *net, u32 devaddr)
Never use inline for functions in a foo.c file, let the compiler decide.
> +{
> + struct net_device *ndev = NULL;
> + __be32 be_addr = cpu_to_be32(devaddr);
Always order local variables from longest to shortest line.
> +static int
> +dgram_recvmsg(struct sock *sk, struct msghdr *msg, size_t len,
> + int noblock, int flags, int *addr_len)
> +{
> + struct sk_buff *skb;
> + size_t copied = 0;
> + DECLARE_SOCKADDR(struct sockaddr_lorawan *, saddr, msg->msg_name);
> + int err;
Likewise.
I'm not going to point out every single place where you have made these
two errors.
Please audit your entire submission and fix the problems wherever they
occur.
Thank you.
