Re: [PATCHv2 wpan-tools] wpan-hwsim: hardware simulator configuration utility

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello.

On 03/10/2018 16:31, Alexander Aring wrote:
> Hi,
> 
> On Wed, Oct 03, 2018 at 10:14:09AM +0200, Stefan Schmidt wrote:
>> Hello.
>>
>> On 30/09/2018 23:52, Alexander Aring wrote:
>>> This patch adds initial support for wpan-hwsim utility to control the
>>> mac802154_hwsim driver over netlink.
>>>
>>> Signed-off-by: Alexander Aring <aring@xxxxxxxxxxxx>
>>> ---
>>>
>>> Forgot if I ever send v2 but my local change has the last complain.
>>> So I resend.
>>>
>>> changes since v2:
>>> - help and version both do not need an argument, please use no_argument
>>> - printf("wpan-hwsim " PACKAGE_VERSION "\n");
>>
>> Patch has been applied to wpan-tools. Thanks for fixing up my review
>> comments.
>>
>> Seems we want to get out a new wpan-tools release in the next weeks to
>> have this utility available. I will see what I can do.
>>
> 
> wait please for a fix... I forgot that dot longarg needs no_argument as
> well...

No problem. We have time to get fixes in. Juts wanted to make sure we
get a new release with the hwsim utility out to match the latest kernel
release.

> I begin to hate that interface. I need to define it for short with ':'
> and then again for long in this struct. I do short sometimes only...
> I will never do long args again, I fall into mistakes.

Yeah, getopt is not the nicest interface, but doing command line option
handling by hand is not nice either.

regards
Stefan Schmidt



[Index of Archives]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux