Hello.
On 06.11.2017 16:32, Harry Morris wrote:
> On 22/09/2017 13:14, Stefan Schmidt wrote:
>> Instead of having the function name hard-coded (it might change and we
>> forgot to update them in the debug output) we can use __func__ instead
>> and also shorter the line so we do not need to break it.
>> Found by checkpatch.
>>
>> Signed-off-by: Stefan Schmidt <stefan@xxxxxxxxxxxxxxx>
>> ---
>> drivers/net/ieee802154/ca8210.c | 8 ++++----
>> 1 file changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/net/ieee802154/ca8210.c
>> b/drivers/net/ieee802154/ca8210.c
>> index 66829055aa8b..26e04c9176a4 100644
>> --- a/drivers/net/ieee802154/ca8210.c
>> +++ b/drivers/net/ieee802154/ca8210.c
>> @@ -924,7 +924,7 @@ static int ca8210_spi_transfer(
>> priv = spi_get_drvdata(spi);
>> reinit_completion(&priv->spi_transfer_complete);
>> - dev_dbg(&spi->dev, "ca8210_spi_transfer called\n");
>> + dev_dbg(&spi->dev, "%s called\n", __func__);
>> cas_ctl = kmalloc(sizeof(*cas_ctl), GFP_ATOMIC);
>> if (!cas_ctl)
>> @@ -1898,7 +1898,7 @@ static int ca8210_net_rx(struct ieee802154_hw
>> *hw, u8 *command, size_t len)
>> unsigned long flags;
>> u8 status;
>> - dev_dbg(&priv->spi->dev, "ca8210_net_rx(), CmdID = %d\n",
>> command[0]);
>> + dev_dbg(&priv->spi->dev, "%s: CmdID = %d\n", __func__, command[0]);
>> if (command[0] == SPI_MCPS_DATA_INDICATION) {
>> /* Received data */
>> @@ -1948,7 +1948,7 @@ static int ca8210_skb_tx(
>> struct secspec secspec;
>> unsigned int mac_len;
>> - dev_dbg(&priv->spi->dev, "ca8210_skb_tx() called\n");
>> + dev_dbg(&priv->spi->dev, "%s called\n", __func__);
>> /* Get addressing info from skb - ieee802154 layer creates a full
>> * packet
>> @@ -2051,7 +2051,7 @@ static int ca8210_xmit_async(struct
>> ieee802154_hw *hw, struct sk_buff *skb)
>> struct ca8210_priv *priv = hw->priv;
>> int status;
>> - dev_dbg(&priv->spi->dev, "calling ca8210_xmit_async()\n");
>> + dev_dbg(&priv->spi->dev, "calling %s\n", __func__);
>> priv->tx_skb = skb;
>> priv->async_tx_pending = true;
>
> Acked-by: Harry Morris <h.morris@xxxxxxxxxxx>
This patch has been applied to the wpan-next tree and will be
part of the next pull request to net-next. Thanks!
regards
Stefan Schmidt
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wpan" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-wpan" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
