Hi Harry, >>> <snip> >>> + >>> + if (ca8210_spi_transfer( >>> + device_ref, &command.command_id, command.length + 2) >>> + ) >> code style here? Did you run checkpatch? > checkpatch didn't throw up any complaints regarding style - from what I can see the kernel guidelines are fairly flexible when it comes to splitting long lines. I'm totally happy to newline each argument or something though eg. > > if (ca8210_spi_transfer( > device_ref, > &command.command_id > command.length + 2) > ) actually checkpatch --strict is what you should be using. ca810_spi_transfer(device_ref, &command.command_id, command.length + 2) Use tabs as much as possible and fill up the rest with spaces to that parameters align. Multiple parameters in the same line is fine. Fill them up as much as possible. Regards Marcel -- To unsubscribe from this list: send the line "unsubscribe linux-wpan" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
