Hi, On 12/20/2016 12:13 PM, Alexander Aring wrote: > > Hi, > > On 12/05/2016 02:47 PM, Stefan Schmidt wrote: >> From firmware version 0.3 onwards we use the TX_ARET mode allowing for automatic >> frame retransmissions. To actually make use of this feature we need to implement >> the callback for setting the frame retries. >> >> If the firmware version is to old print a warning and return with invalid value. >> >> Signed-off-by: Stefan Schmidt <stefan@xxxxxxxxxxxxxxx> >> --- >> drivers/net/ieee802154/atusb.c | 19 ++++++++++++++++++- >> 1 file changed, 18 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/net/ieee802154/atusb.c b/drivers/net/ieee802154/atusb.c >> index 3ed34cc..1253f86 100644 >> --- a/drivers/net/ieee802154/atusb.c >> +++ b/drivers/net/ieee802154/atusb.c >> @@ -546,6 +546,21 @@ atusb_set_csma_params(struct ieee802154_hw *hw, u8 min_be, u8 max_be, u8 retries >> } >> >> static int >> +atusb_set_frame_retries(struct ieee802154_hw *hw, s8 retries) >> +{ >> + struct atusb *atusb = hw->priv; >> + struct device *dev = &atusb->usb_dev->dev; >> + >> + if (atusb->fw_ver_maj == 0 && atusb->fw_ver_min < 3) { >> + dev_info(dev, "Automatic frame retransmission is only available from " >> + "firmware version 0.3. Please update if you want this feature."); >> + return -EINVAL; >> + } >> + > > I think the user has not change anymore to use atusb driver with new > firmware now. > meant, has no chance anymore to use new atusb driver with old firmware... - Alex -- To unsubscribe from this list: send the line "unsubscribe linux-wpan" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html