Hello.
On 09/12/16 09:22, Marcel Holtmann wrote:
Hi Stefan,
I do not see myself in the CC list and I got 2/3 and 3/3 via linux-wpan mailing list.
That's bizarre, am I missing something about how emails work?
From: harrymorris12@xxxxxxxxx
X-Google-Original-From:
h.morris@xxxxxxxxxxx
To:
linux-wpan@xxxxxxxxxxxxxxx
Cc:
aar@xxxxxxxxxxxxxx
,
stefan@xxxxxxxxxxxxxxx
,
marcel@xxxxxxxxxxxx
,
Harry Morris
<h.morris@xxxxxxxxxxx>
Subject: [PATCH v6 1/3] ieee802154: Add CA8210 IEEE 802.15.4 device driver
Date: Tue, 6 Dec 2016 15:47:38 +0000
I've forwarded the original to your address individually, please let me know if you receive it.
I got the forwarded one, but not the other. And as you can see in my Reply-All, I was not on the CC list. Anyhow, either the forwarded one got mangled or it does not apply clean to bluetooth-next tree. Please fix that re-submit.
As an alternative to ease things up here you could go with the following pull request which has the 3 patches from harry on top of your latest pull request to DaveM. They applied and compiled cleanly here for me. If you wanna take this one or wait for the re-submit from Harry is up to you. Just thought it might be worth preparing this as I already had the patches in my tree for testing. :)
The following changes since commit 107bc0aa95ca572df42da43c30a2079266e992e4:
Merge branch 'for-upstream' of git://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth-next (2016-12-08 14:33:17 -0500)
are available in the git repository at:
https://github.com/linux-wpan/linux-wpan-next.git for-next
for you to fetch changes up to c8e4b45529a0d608b50f93cc54e03e749fab67af:
ieee802154: Add entry in MAINTAINTERS for CA8210 driver (2016-12-09 08:35:12 +0100)
----------------------------------------------------------------
Harry Morris (3):
ieee802154: Add CA8210 IEEE 802.15.4 device driver
ieee802154: Add device tree documentation for CA8210
ieee802154: Add entry in MAINTAINTERS for CA8210 driver
Documentation/devicetree/bindings/net/ieee802154/ca8210.txt | 28 +
Documentation/devicetree/bindings/vendor-prefixes.txt | 1 +
MAINTAINERS | 9 +
drivers/net/ieee802154/Kconfig | 21 +
drivers/net/ieee802154/Makefile | 1 +
drivers/net/ieee802154/ca8210.c | 3719 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
6 files changed, 3779 insertions(+)
create mode 100644 Documentation/devicetree/bindings/net/ieee802154/ca8210.txt
create mode 100644 drivers/net/ieee802154/ca8210.c
CC drivers/net/ieee802154/ca8210.o
drivers/net/ieee802154/ca8210.c: In function ‘ca8210_test_int_user_write’:
drivers/net/ieee802154/ca8210.c:2878:50: warning: format ‘%d’ expects argument of type ‘int’, but argument 3 has type ‘size_t {aka long unsigned int}’ [-Wformat=]
"userspace requested erroneously long write (%d)\n",
^
drivers/net/ieee802154/ca8210.c: In function ‘ca8210_register_ext_clock’:
drivers/net/ieee802154/ca8210.c:3159:14: error: implicit declaration of function ‘clk_register_fixed_rate’ [-Werror=implicit-function-declaratio]
priv->clk = clk_register_fixed_rate(
^~~~~~~~~~~~~~~~~~~~~~~
drivers/net/ieee802154/ca8210.c:3159:12: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
priv->clk = clk_register_fixed_rate(
^
drivers/net/ieee802154/ca8210.c:3171:8: error: implicit declaration of function ‘of_clk_add_provider’ [-Werror=implicit-function-declaration]
ret = of_clk_add_provider(np, of_clk_src_simple_get, priv->clk);
^~~~~~~~~~~~~~~~~~~
drivers/net/ieee802154/ca8210.c:3171:32: error: ‘of_clk_src_simple_get’ undeclared (first use in this function)
ret = of_clk_add_provider(np, of_clk_src_simple_get, priv->clk);
^~~~~~~~~~~~~~~~~~~~~
drivers/net/ieee802154/ca8210.c:3171:32: note: each undeclared identifier is reported only once for each function it appears in
drivers/net/ieee802154/ca8210.c:3173:3: error: implicit declaration of function ‘clk_unregister’ [-Werror=implicit-function-declaration]
clk_unregister(priv->clk);
^~~~~~~~~~~~~~
drivers/net/ieee802154/ca8210.c: In function ‘ca8210_unregister_ext_clock’:
drivers/net/ieee802154/ca8210.c:3197:2: error: implicit declaration of function ‘of_clk_del_provider’ [-Werror=implicit-function-declaration]
of_clk_del_provider(spi->dev.of_node);
^~~~~~~~~~~~~~~~~~~
drivers/net/ieee802154/ca8210.c:3197:2: warning: ‘return’ with a value, in function returning void
of_clk_del_provider(spi->dev.of_node);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/net/ieee802154/ca8210.c:3190:13: note: declared here
static void ca8210_unregister_ext_clock(struct spi_device *spi)
^~~~~~~~~~~~~~~~~~~~~~~~~~~
Grr, this should not happen when I send you things. Sorry. One step back.
Harry, please fix this warnings and errors.
And I will have to see why I did not see them and improve my build tests
here to spot them next time.
regards
Stefan Schmidt
--
To unsubscribe from this list: send the line "unsubscribe linux-wpan" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
