Hi Stefan,
On 06/12/2016 21:25, Stefan Schmidt wrote:
Hello.
First of all thanks for going and fixing almost all of the checkpatch
warnings. The rest seems ok to stay as is.
I would expect you made sure that the case where a msleep() could take
up to 20ms in cases it is < 20ms are no problems in your driver.
Great, and yes those 1ms msleeps are all a part of "Some condition isn't
fulfilled yet so wait for <some time> and check again", so if it's a bit
longer it's totally fine.
On 06/12/16 16:47, harrymorris12@xxxxxxxxx wrote:
From: Harry Morris <h.morris@xxxxxxxxxxx>
Add driver source and config for softMAC implementation of Cascoda's
CA8210
IEEE 802.15.4 transceiver device. The driver mimics a common PHY-only
implementation despite the CA8210 being a hardMAC device which
exposes a SAP
interface to the fully integrated MAC.
The chip is a modem-only device with an integrated processor which
runs the
802.15.4 MAC. The chip communicates via full-duplex SPI with
additional pins
for NIRQ and NRESET. The chip can also output its 16MHz clock to a
GPIO with a
configurable divider.
The driver can be configured to implement a debugfs node that
provides access
to the SAP-based API to drive mechanisms not currently supported by the
standard kernel interface.
Signed-off-by: Harry Morris <h.morris@xxxxxxxxxxx>
From what I can see all my review comments have been addressed over
this 7 iterations. Thanks. :-)
No worries,
Regards,
Harry
--
To unsubscribe from this list: send the line "unsubscribe linux-wpan" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
