Re: [PATCH 2/3] ieee802154: Add device tree documentation for CA8210

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Stefan,

On 25/10/2016 16:54, Stefan Schmidt wrote:
Start should with a capital S here as you do on all other lines. Total nitpick. :)
Perfect, I'm sure there's a few more elsewhere I've missed
+    - reg:                  Controlling chip select
+    - spi-max-frequency:    Maximum clock speed, should be *less than*
+                            4000000
+    - spi-cpol:             Invert clock polarity

Is this a mandatory field for the bindings? I would expect one being the default and used while the other one being an optional property and only used when the hardware setup needs this. Does this make sense?
I'm afraid not, my understanding is that the spi-cpol property is used by the spi master driver rather than the device driver, so if I need CPOL=1 (which the CA8210 always does) then the user doesn't have a choice but to specify spi-cpol here? As omitting would cause the spi master to use CPOL=0 for the attached slave.

Regards,
Harry
--
To unsubscribe from this list: send the line "unsubscribe linux-wpan" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux