Re: [PATCH wpan-tools 2/2] phy: add netns support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On 05/11/2016 05:13 PM, Stefan Schmidt wrote:
> Hello.
> 
> Quick tip. If you want to check your code with coverity before putting it into master you can push it to the branch coverty_scan on github and travis will build and submit it to coverity. I find this handy when doing new code to check it before putting it into master. Nothing wrong with this code just a tip. :)
> 

ok, I will try it put don't be angry if everything is broken afterwards.
:-)

> On 11/05/16 11:46, Alexander Aring wrote:
>> This patch adds netns support, basically most parts are copy&pasted from
>> iw tool, same handling just wpan instead wireless.
>>
>> Signed-off-by: Alexander Aring <aar@xxxxxxxxxxxxxx>
>> ---
>>   src/phy.c | 66 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>>   1 file changed, 66 insertions(+)
>>
>> diff --git a/src/phy.c b/src/phy.c
>> index 816bdd8..887b610 100644
>> --- a/src/phy.c
>> +++ b/src/phy.c
>> @@ -2,6 +2,10 @@
>>   #include <errno.h>
>>   #include <string.h>
>>   #include <stdbool.h>
>> +#include <sys/param.h>
>> +#include <sys/types.h>
>> +#include <sys/stat.h>
>> +#include <fcntl.h>
>>     #include <netlink/genl/genl.h>
>>   #include <netlink/genl/family.h>
>> @@ -144,3 +148,65 @@ nla_put_failure:
>>   }
>>   COMMAND(set, cca_ed_level, "<level>",
>>       NL802154_CMD_SET_CCA_ED_LEVEL, 0, CIB_PHY, handle_cca_ed_level, NULL);
>> +
>> +#ifndef NETNS_RUN_DIR
>> +#define NETNS_RUN_DIR "/var/run/netns"
>> +#endif
>> +int netns_get_fd(const char *name)
> Make this function static?
> 

ok.

- Alex
--
To unsubscribe from this list: send the line "unsubscribe linux-wpan" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux