Hello.
On 22/03/16 14:14, Alexander Aring wrote:
he whole generating of autoconfiguration IPv6 link-local addresses based
on a notification on interface up.
Maybe this?
"The generation of autoconfigured IPv6 link-local addresses starts with
a notification on interface up."
These addresses are based on mac
addresses and are not changeable during interface up of IPv6 interfaces.
This patch will disallow mac address changes while a lowpan interface
for a wpan interface is up.
It might be worthwhile mentioning why we disallow the change of pan_id
and short address here while you talk about the mac address. Knowing
that pan_id plus some padding plus short address can be used as
permanent address for SLA is not common knowledge.
Signed-off-by: Alexander Aring<aar@xxxxxxxxxxxxxx>
---
net/ieee802154/nl802154.c | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/net/ieee802154/nl802154.c b/net/ieee802154/nl802154.c
index 16ef0d9..5f1dc4b 100644
--- a/net/ieee802154/nl802154.c
+++ b/net/ieee802154/nl802154.c
@@ -1074,6 +1074,11 @@ static int nl802154_set_pan_id(struct sk_buff *skb, struct genl_info *info)
if (netif_running(dev))
return -EBUSY;
+ if (wpan_dev->lowpan_dev) {
+ if (netif_running(wpan_dev->lowpan_dev))
+ return -EBUSY;
+ }
+
/* don't change address fields on monitor */
if (wpan_dev->iftype == NL802154_IFTYPE_MONITOR ||
!info->attrs[NL802154_ATTR_PAN_ID])
@@ -1105,6 +1110,11 @@ static int nl802154_set_short_addr(struct sk_buff *skb, struct genl_info *info)
if (netif_running(dev))
return -EBUSY;
+ if (wpan_dev->lowpan_dev) {
+ if (netif_running(wpan_dev->lowpan_dev))
+ return -EBUSY;
+ }
+
/* don't change address fields on monitor */
if (wpan_dev->iftype == NL802154_IFTYPE_MONITOR ||
!info->attrs[NL802154_ATTR_SHORT_ADDR])
While I truly dislike behaviour changes I consider this one an actual
bug fix as changing these values during runtime would not trigger a SLA
change and we would thus be out of sync address wise which can lead to
reall problematic situations.
Reviewed-by: Stefan Schmidt <stefan@xxxxxxxxxxxxxxx>
regards
Stefan Schmidt
--
To unsubscribe from this list: send the line "unsubscribe linux-wpan" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
