Re: [PATCH v2] drivers/net/ieee802154/adf7242: Driver for ADF7242 MAC IEEE802154

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 12/08/2015 03:30 PM, Stefan Schmidt wrote:
Hello.

One last thing, hopefully. :)

On 08/12/15 12:52, michael.hennerich@xxxxxxxxxx wrote:

[snip]
+
+    dev_info(&spi->dev, "mac802154 IRQ-%d registered\n", spi->irq);
+
+    return ret;
+
+    ieee802154_unregister_hw(lp->hw);

The function call after return will never be called. Guess you want to
make sure the error handling is correct here.


Yeah - this line can be removed completely.
Thanks for pointing out.



+err_hw_init:
+    mutex_destroy(&lp->bmux);
+    ieee802154_free_hw(lp->hw);

regards
Stefan Schmidt


--
Greetings,
Michael

--
Analog Devices GmbH      Wilhelm-Wagenfeld-Str. 6      80807 Muenchen
Sitz der Gesellschaft: Muenchen; Registergericht: Muenchen HRB 40368;
Geschaeftsfuehrer:Dr.Carsten Suckrow, Thomas Wessel, William A. Martin,
Margaret Seif
--
To unsubscribe from this list: send the line "unsubscribe linux-wpan" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux