Re: [RFCv2 bluetooth-next 09/16] ieee802154: 6lowpan: earlier skb->dev switch

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello.

On 30/08/15 23:54, Stefan Schmidt wrote:
Hello.

On 20/08/15 18:47, Alexander Aring wrote:
We should change the skb->dev pointer earlier to the lowpan interface
Sometimes we call iphc_decompress which also use some netdev printout
functionality. This patch will change that the correct interface will be
displayed in this case, which should be the lowpan interface.

Signed-off-by: Alexander Aring <alex.aring@xxxxxxxxx>
---
  net/ieee802154/6lowpan/rx.c | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/net/ieee802154/6lowpan/rx.c b/net/ieee802154/6lowpan/rx.c
index 74d8fec..f9cb70b 100644
--- a/net/ieee802154/6lowpan/rx.c
+++ b/net/ieee802154/6lowpan/rx.c
@@ -18,7 +18,6 @@
  static int lowpan_give_skb_to_device(struct sk_buff *skb,
                       struct net_device *wdev)
  {
-    skb->dev = wdev->ieee802154_ptr->lowpan_dev;
      skb->protocol = htons(ETH_P_IPV6);
      skb->pkt_type = PACKET_HOST;
@@ -71,9 +70,11 @@ static int lowpan_rcv(struct sk_buff *skb, struct net_device *wdev,
      if (!ldev || !netif_running(ldev))
          goto drop;
+ /* Replacing skb->dev and followed rx handlers will manipulate skb. */
      skb = skb_share_check(skb, GFP_ATOMIC);
      if (!skb)
          goto drop;
+    skb->dev = ldev;
        if (ieee802154_hdr_peek_addrs(skb, &hdr) < 0)
          goto drop_skb;

Signed-off-by: Stefan Schmidt <stefan@xxxxxxxxxxxxxxx>


This should also have been

Reviewed-by: Stefan Schmidt <stefan@xxxxxxxxxxxxxxx>

regards
Stefan Schmidt
--
To unsubscribe from this list: send the line "unsubscribe linux-wpan" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux