Re: [RFC bluetooth-next 06/21] mrf24j40: add default channel setting

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello.

On 13/08/15 14:22, Alexander Aring wrote:
Per default mrf24j40 has the channel 11 after reset. This patch adds the
right phy default value for the channel setting.

Signed-off-by: Alexander Aring <alex.aring@xxxxxxxxx>
---
  drivers/net/ieee802154/mrf24j40.c | 7 +++++++
  1 file changed, 7 insertions(+)

diff --git a/drivers/net/ieee802154/mrf24j40.c b/drivers/net/ieee802154/mrf24j40.c
index 7df80d8..4051310 100644
--- a/drivers/net/ieee802154/mrf24j40.c
+++ b/drivers/net/ieee802154/mrf24j40.c
@@ -720,6 +720,11 @@ err_ret:
  	return ret;
  }
+static void mrf24j40_phy_setup(struct mrf24j40 *devrec)
+{
+	devrec->hw->phy->current_channel = 11;
+}
+

I was about to write here that a new function just for this might be a bit to much but looking down further the patchset I can see that you are adding more and more phy related bits here so its fine to introduce it here.
  static int mrf24j40_probe(struct spi_device *spi)
  {
  	int ret = -ENOMEM;
@@ -753,6 +758,8 @@ static int mrf24j40_probe(struct spi_device *spi)
  	if (ret)
  		goto err_register_device;
+ mrf24j40_phy_setup(devrec);
+
  	ret = devm_request_threaded_irq(&spi->dev,
  					spi->irq,
  					NULL,

Reviewed-by: Stefan Schmidt <stefan@xxxxxxxxxxxxxxx>

regards
Stefan Schmidt
--
To unsubscribe from this list: send the line "unsubscribe linux-wpan" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux