[PATCH wpan-tools] mac: range checking for command accepting only 0 or 1

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



lbt and ackreq_default only accept 0or 1 as arguments which we did not
acount for so far. Testing invalid arguments and checking teh return
code uncovered this one.

Signed-off-by: Stefan Schmidt <stefan@xxxxxxxxxxxxxxx>
---
 src/mac.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/src/mac.c b/src/mac.c
index 76db58f..26c6fc5 100644
--- a/src/mac.c
+++ b/src/mac.c
@@ -175,6 +175,8 @@ static int handle_lbt_mode(struct nl802154_state *state,
 	mode = strtoul(argv[0], &end, 0);
 	if (*end != '\0')
 		return 1;
+	if (mode != 0 && mode != 1)
+		return 1;
 
 	NLA_PUT_U8(msg, NL802154_ATTR_LBT_MODE, mode);
 
@@ -202,6 +204,8 @@ static int handle_ackreq_default(struct nl802154_state *state,
 	ackreq = strtoul(argv[0], &end, 0);
 	if (*end != '\0')
 		return 1;
+	if (ackreq != 0 && ackreq != 1)
+		return 1;
 
 	NLA_PUT_U8(msg, NL802154_ATTR_ACKREQ_DEFAULT, ackreq);
 
-- 
2.4.3

--
To unsubscribe from this list: send the line "unsubscribe linux-wpan" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux