Hello.
On 03/08/15 08:23, Alexander Aring wrote:
This patch adds checks for reserved dispatch value by check on all known
dispatch values.
Signed-off-by: Alexander Aring<alex.aring@xxxxxxxxx>
---
net/ieee802154/6lowpan/rx.c | 12 +++++++++++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/net/ieee802154/6lowpan/rx.c b/net/ieee802154/6lowpan/rx.c
index 146aa14..48869ac 100644
--- a/net/ieee802154/6lowpan/rx.c
+++ b/net/ieee802154/6lowpan/rx.c
@@ -248,6 +248,15 @@ static inline bool lowpan_is_nalp(u8 dispatch)
return (dispatch & LOWPAN_DISPATCH_FIRST) == LOWPAN_DISPATCH_NALP;
}
+static inline bool lowpan_is_reserved(u8 dispatch)
+{
+ return !(lowpan_is_nalp(dispatch) || lowpan_is_iphc(dispatch) ||
OK, this is fishy. First of all you check lowpan_is_nalp here and negate
it, but below you are checking without negation.
One must be wrong. :)
+ lowpan_is_ipv6(dispatch) || lowpan_is_hc1(dispatch) ||
+ lowpan_is_bc0(dispatch) || lowpan_is_mesh(dispatch) ||
+ lowpan_is_esc(dispatch) || lowpan_is_frag1(dispatch) ||
+ lowpan_is_fragn(dispatch));
+}
+
/* lowpan_rx_h_check checks on generic 6LoWPAN requirements
* in MAC and 6LoWPAN header.
*
@@ -259,7 +268,8 @@ static bool lowpan_rx_h_check(struct sk_buff *skb)
if (unlikely(!skb->len))
return false;
- if (lowpan_is_nalp(*skb_network_header(skb)))
+ if (lowpan_is_nalp(*skb_network_header(skb)) ||
Here are you checking it as well. but without negating it.
+ lowpan_is_reserved(*skb_network_header(skb)))
return false;
return true;
regards
Stefan Schmidt
--
To unsubscribe from this list: send the line "unsubscribe linux-wpan" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
