RE: [RFC v2 3/4] 6lowpan: Add stateful compression support for iphc.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Alex,

> On Mon, Jul 13, 2015 at 01:50:32PM +0200, Lukasz Duda wrote:
> ...
> >  		} else {
> >  			pr_debug("dest address unicast %pI6c\n", &hdr-
> >daddr);
> >  			lowpan_push_hc_data(&hc_ptr, hdr->daddr.s6_addr,
> 16); @@ -619,6
> > +774,9 @@ static int __init lowpan_module_init(void)  {
> >  	lowpan_debugfs = debugfs_create_dir("6lowpan", NULL);
> >
> > +	/* Initialize stateful compression. */
> > +	lowpan_context_init();
> > +
> 
> Error handling here, too. You need to change lowpan_context_init for
> returning return value from debugfs_create_file then.
> 
> The rest will I review when I get it running. :-)
> 
> - Alex

Thanks for comment! 

I am certainly going to add this check on debugfs_create. The reason being is that I tried to fit into /net/bluetooth code part as
much as I can and I didn't find such checks there :)

Regards,
Łukasz
��.n��������+%������w��{.n�����{��
Z���ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f




[Index of Archives]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux