On Thu, June 25, 2015 11:23 am, Varka Bhadram wrote: > Hello, > > On 06/25/2015 02:10 PM, Phoebe Buckheister wrote: > >> On Thu, June 25, 2015 10:23 am, Varka Bhadram wrote: >>> Hi Phoebe Buckheister, >>> >>> On 06/25/2015 01:13 PM, Phoebe Buckheister wrote: >>>> On Thu, June 25, 2015 9:29 am, Stefan Schmidt wrote: >>>>> Hello. >>>>> >>>>> On 25/06/15 08:31, Varka Bhadram wrote: >>>>>> This patch rename ieee802154_hdr member seq to sequence_number. >>>>> Any good reason for this? I think seq is quite clear in this context >>>>> and >>>>> making it sequence_number has no real benefit. >>>>> >>>>> If others disagree I'm fine to let that one in though. No hard >>>>> feelings >>>>> about it. >>>> Don't see the in renaming this either. >>> I didn't get your point. ? >> The "point" went missing. I don't see why renaming this symbol is >> necessary or useful. Like Stefan said, it is pretty clear from context, >> and sequence_number is kind of long too. >> > As part of the rework on frame parsing, Alex used this naming convention > [1]. > > If you think that it's too long, can we use *seq_num* instead of *seq* ? Sure. Just avoid overly long names when a shorter one will do. Still not a friend of remaining that now if it'll be replaced anyway. > > [1]: > https://github.com/linux-wpan/linux-wpan-next/blob/wpan_rework_rfc/include/net/ieee802154.h#L160 > > -- > Varka Bhadram. > > -- To unsubscribe from this list: send the line "unsubscribe linux-wpan" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
