Re: [PATCH bluetooth-next] nl802154: export supported commands

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 06/03/2015 12:19 PM, Alexander Aring wrote:

Hi,

On Wed, Jun 03, 2015 at 09:44:01AM +0530, Varka Bhadram wrote:
This patch will export the supported commands by the devices
to the user. This is required because user should know supported
commands by the IEEE-802.15.4 devices. Drivers that are there in
the mainline are not supporting all the functionalities that the
core is providing to us.

I think this is not the reason why this was implemented. You check here
cfg802154_ops which ends in mac802154 (SoftMAC) OR _possible_ HardMAC drivers.

If you want to make sure that a driver implement it _and_ really sure
you need to check on ieee802154_ops.

I suppose the real reason why wireless has this implementation, is
because to check if HardMAC drivers can support a specific command.
This is because every HardMAC driver should implement then the full
cfg802154_ops callback structure. It's simple wrong here to say "to
check if the driver support the functionalities".

I found this thread for the reason used in wireless for implementation.

http://www.spinics.net/lists/linux-wireless/msg29923.html

You skip the mac802154 layer here, these calls are direct driver-layer
calls in case of HardMAC driver only.


Currently that's why I think such feature has _at_ _the_ _moment_ no
really big use case, because we don't have any HardMAC driver currently.
Anyway this prepares to handle HardMAC drivers. After fixing the commit
message you can add a:

Acked-by: Alexander Aring <alex.aring@xxxxxxxxx>

Thanks

--
Varka Bhadram

--
To unsubscribe from this list: send the line "unsubscribe linux-wpan" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux