On Fri, Apr 24, 2015 at 10:13:11AM +0530, Varka Bhadram wrote:
> On 04/23/2015 10:17 PM, Alexander Aring wrote:
>
> > This patch add support to nl802154 to dump all phy capabilities which is
> > inside the wpan_phy_supported struct. Also we introduce a new method to
> > dumping supported channels. The new method will offer a easier interface
> > and has lesser netlink traffic.
> >
> > Signed-off-by: Alexander Aring <alex.aring@xxxxxxxxx>
> > ---
> > include/net/nl802154.h | 57 ++++++++++++++++++++
> > net/ieee802154/nl802154.c | 131 +++++++++++++++++++++++++++++++++++++++++++++-
> > 2 files changed, 187 insertions(+), 1 deletion(-)
> >
> > diff --git a/include/net/nl802154.h b/include/net/nl802154.h
> > index 0552771..8c49714 100644
> > --- a/include/net/nl802154.h
> > +++ b/include/net/nl802154.h
> > @@ -100,6 +100,8 @@ enum nl802154_attrs {
> >
> > NL802154_ATTR_EXTENDED_ADDR,
> >
> > + NL802154_ATTR_WPAN_PHY_CAPS,
> > +
> > /* add attributes here, update the policy in nl802154.c */
> >
> > __NL802154_ATTR_AFTER_LAST,
> > @@ -120,6 +122,61 @@ enum nl802154_iftype {
> > };
> >
> > /**
> > + * enum nl802154_wpan_phy_capability_attr - capability attributes
> > + *
>
> instead of capability attributes also add wpan phy in-front of it.
>
> * wpan phy capability attributes *
>
> > + * @__NL802154_CAP_ATTR_INVALID: attribute number 0 is reserved
> > + * @NL802154_CAP_ATTR_CHANNELS: a nested attribute for nl802154_channel_attr
> > + * @NL802154_CAP_ATTR_TX_POWERS: a nested attribute for
> > + * nl802154_wpan_phy_tx_power
> > + * @NL802154_CAP_ATTR_MIN_CCA_ED_LEVEL: minimum value for cca_ed_level
> > + * @NL802154_CAP_ATTR_MAX_CCA_ED_LEVEL: maxmimum value for cca_ed_level
> > + * @NL802154_CAP_ATTR_CCA_MODES: nl802154_cca_modes flags
> > + * @NL802154_CAP_ATTR_CCA_OPTS: nl802154_cca_opts flags
> > + * @NL802154_CAP_ATTR_MIN_MINBE: minimum of minbe value
> > + * @NL802154_CAP_ATTR_MAX_MINBE: maximum of minbe value
> > + * @NL802154_CAP_ATTR_MIN_MAXBE: minimum of maxbe value
> > + * @NL802154_CAP_ATTR_MAX_MINBE: maximum of maxbe value
> > + * @NL802154_CAP_ATTR_MIN_CSMA_BACKOFFS: minimum of csma backoff value
> > + * @NL802154_CAP_ATTR_MAX_CSMA_BACKOFFS: maximum of csma backoffs value
> > + * @NL802154_CAP_ATTR_MIN_FRAME_RETRIES: minimum of frame retries value
> > + * @NL802154_CAP_ATTR_MAX_FRAME_RETRIES: maximum of frame retries value
> > + * @NL802154_CAP_ATTR_IFTYPES: nl802154_iftype flags
> > + * @NL802154_CAP_ATTR_LBT: nl802154_supported_bool_states flags
> > + * @NL802154_CAP_ATTR_MAX: highest cap attribute currently defined
> > + * @__NL802154_CAP_ATTR_AFTER_LAST: internal use
> > + */
> > +enum nl802154_capability_attr {
>
> enum name mismatch. should be *nl802154_wpan_phy_capability_attr*.
>
ok, thanks. This header very important to be correct, otherwise users
getting angry. :-)
- Alex
--
To unsubscribe from this list: send the line "unsubscribe linux-wpan" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
