Re: First kernel patch - checkpatch for at86rf230.c, false-positives?

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Apr 23, 2015 at 12:25:34PM +0200, Christoffer Holmstedt wrote:
...
> 
> Thank you Alexander for your fast and thorough response, I expected
> something like that as other defines did have parantheses.
> 

if you like to send a first patch, maybe to "breaking the ice". Then I
see several cleanups there, like I used some magic values for masking
the trac status or trx state e.g. "trx_state = buf[1] & 0x1f;". You can
introduce some macro for that and replacing it where it used.

Or simple sending some patches for whatever you want, I/community will review
them.

With "breaking the ice", I mean some "testing linux send patch
environment" and getting familiar with sending patches. When it is your
first time.

- Alex
--
To unsubscribe from this list: send the line "unsubscribe linux-wpan" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux