Re: [PATCH bluetooth-next] mac802154: fix transmission power datatype

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Varka,

>>> Available 802.15.4 devices support multiple power levels,
>>> which includes positive and negative values.This patch fix
>>> set_txpower() operation arugument type to signed from int
>>> 
>>> Signed-off-by: Varka Bhadram <varkab@xxxxxxx>
>>> ---
>>> include/net/mac802154.h |    2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>> 
>>> diff --git a/include/net/mac802154.h b/include/net/mac802154.h
>>> index fb4e8a3d..1213419 100644
>>> --- a/include/net/mac802154.h
>>> +++ b/include/net/mac802154.h
>>> @@ -213,7 +213,7 @@ struct ieee802154_ops {
>>> 	int		(*set_hw_addr_filt)(struct ieee802154_hw *hw,
>>> 					    struct ieee802154_hw_addr_filt *filt,
>>> 					    unsigned long changed);
>>> -	int		(*set_txpower)(struct ieee802154_hw *hw, int db);
>>> +	int		(*set_txpower)(struct ieee802154_hw *hw, s8 dbm);
>> the commit message is pretty much non-sense. int is as signed as s8.
> 
> The netlink attribute for the power level is s8. At mac level the values
> stored in s8 only [1].

sure, but the commit message is still non-sense.

Regards

Marcel

--
To unsubscribe from this list: send the line "unsubscribe linux-wpan" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux