Re: [PATCH bluetooth-next] mac802154: fix typo for device

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Alex,

>> Signed-off-by: Varka Bhadram <varkab@xxxxxxx>
>> ---
>> include/net/mac802154.h |    2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/include/net/mac802154.h b/include/net/mac802154.h
>> index d6a809e..56ef97a 100644
>> --- a/include/net/mac802154.h
>> +++ b/include/net/mac802154.h
>> @@ -247,7 +247,7 @@ static inline void ieee802154_le64_to_be64(void *be64_dst, const void *le64_src)
>> 	__put_unaligned_memmove64(swab64p(le64_src), be64_dst);
>> }
>> 
>> -/* Basic interface to register ieee802154 hwice */
>> +/* Basic interface to register ieee802154 device */
> 
> This typo occured when I did a 's/dev/hw/' in my editor. This replaced
> all dev to hw.
> 
> I did this because the variable was always named "dev" which was very
> confusing to handle between netdev "dev" and this one. Look at commit:
> 
> 5a50439775853a8d565115edb63a5ab4bb780479 ("ieee802154: rename
> ieee802154_dev to ieee802154_hw")
> 
> For keeping the wireless naming conventation.
> 
> This also means that calling this "device" is wrong and "hw" is correct.
> So we should change the comment to:
> 
> /* Basic interface to register ieee802154 hw */
> 
> or
> 
> /* Basic interface to register ieee802154 hardware */

so I took this patch already since it was obviously making it better than it was before. Once you decide on how you want to handle the comments, please just send cleanup patches that fix all locations.

Regards

Marcel

--
To unsubscribe from this list: send the line "unsubscribe linux-wpan" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux