Hi, I've updated the patch. I changed the `amplified` param to be a bool which was straightforward once I learned that device tree entries can have empty properties. I added a second commit that should take of the issue of platform_data not being read-only in cc2520_hw_init. Let me know if I can improve it, although it is mostly copied from the at86rf230.c version. I didn't think it was necessary to pass each item in the cc2520_platform_data struct individually and instead just pass the struct to get_platform_data. I have tested the patch with both a CC2520 and a CC2520+CC2591 combination. The patch boils down to just sending different register settings for the CC2520 and seems to work because I can send and receive with both radios. Thank you for looking over the patch and let me know if there is anything else I should fix. Brad changes since v1: - change how platform_data is handled - make amplified a bool instead of int Brad Campbell (2): cc2520: Do not store platform_data in spi_device cc2520: Add support for CC2591 amplifier. .../devicetree/bindings/net/ieee802154/cc2520.txt | 4 + drivers/net/ieee802154/cc2520.c | 148 +++++++++++++-------- include/linux/spi/cc2520.h | 1 + 3 files changed, 96 insertions(+), 57 deletions(-) -- 2.3.2 -- To unsubscribe from this list: send the line "unsubscribe linux-wpan" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html