Hi Marc, On Tue, Feb 24, 2015 at 11:21:43AM +0100, Marc Kleine-Budde wrote: > On 02/24/2015 11:11 AM, Alexander Aring wrote: > > This patch adds support for setting the xtal trim register. Some at86rf2xx > > transceiver boards needs fine tuning the xtal capacitor. > > > > Signed-off-by: Alexander Aring <alex.aring@xxxxxxxxx> > > --- > > .../devicetree/bindings/net/ieee802154/at86rf230.txt | 3 +++ > > drivers/net/ieee802154/at86rf230.c | 12 ++++++++++++ > > include/linux/spi/at86rf230.h | 1 + > > 3 files changed, 16 insertions(+) > > ... > > @@ -1390,6 +1397,10 @@ static int at86rf230_get_pdata(struct spi_device *spi, > > > > cfg->rstn = of_get_named_gpio(spi->dev.of_node, "reset-gpio", 0); > > cfg->slp_tr = of_get_named_gpio(spi->dev.of_node, "sleep-gpio", 0); > > + ret = of_property_read_u8(spi->dev.of_node, "xtal-trim", > > + &cfg->xtal_trim); > > + if (ret < 0 && ret != -EINVAL) > > + return ret; > > > > return 0; > > } > > @@ -1545,6 +1556,7 @@ static int at86rf230_probe(struct spi_device *spi) > > lp = hw->priv; > > lp->hw = hw; > > lp->spi = spi; > > + lp->cfg = cfg; > > This doesn't look correct. You mean the line: "lp->cfg = cfg;" or everything? I copy there the "temporary on stack" allocated platform data to at86rf230_local cfg, which is the platform data allocated on the heap in the at86rf230_local struct. The "temporary on stack" platform data is to not use the "real platform_data" for requesting several pins. Afterwards I copy the platform_data from stack to the at86rf230_local. I can't do this directly because we allocate space for at86rf230_local after requesting pins and do reset, etc.. - Alex -- To unsubscribe from this list: send the line "unsubscribe linux-wpan" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
