On Tue, Jan 20, 2015 at 11:05:26AM +0000, Stefan Schmidt wrote: > Hello. > > On 20/01/15 11:35, Alexander Aring wrote: > >This patch shorten all commands. I had the idea to make a similarity > >from PIB/MIB values according the 802.15.4 names convention but this is > >bad for fast shell hacking. Mainly I remove the underscore and some > >additional information which are not necessary like "_addr" in > >"short_addr" and "extended_addr" and such things. > > > >Signed-off-by: Alexander Aring <alex.aring@xxxxxxxxx> > >--- > > src/info.c | 10 +++++----- > > src/interface.c | 20 ++++++++++---------- > > src/mac.c | 10 +++++----- > > src/phy.c | 6 +++--- > > 4 files changed, 23 insertions(+), 23 deletions(-) > > Hmm, it feels like you are going overboard with shorting things here. Why is > the reason behind it? Just less typing? Shell auto completion would handle > this. :) > it's just less typing and I notice that the original iw command doesn't have an underscore in their commands. The first time when I hacked it, then I just took the same naming convention in kernel implementation which use the naming convention from 802.15.4 standard (without the beginning "MAC" and "PHY" keywords). Now I am too lazy to always type pan_id short_addr, etc... Do you like to implement some completion stuff which can be shipped out optionally with the wpan-tools? :-) > I mean it is up to you but with this you might break scripts that are > already out there and I think the current commands are quite fine. Cutting > out the underscores makes some of these hard to read imho. > mhhh, I am unsure also about this and just gave it a try if somebody screams I would maybe reconsider this patch. :-) - Alex -- To unsubscribe from this list: send the line "unsubscribe linux-wpan" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
