Re: [PATCH bluetooth-next] af_ieee802154: make header uapi conform

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Alex,

> This patch uses __u16 and __u8 instead of u16 and u8 typedefs. These
> typedefs coming from linux/types.h and are also easily available in
> standard userspace environments. The af_ieee802154 header is normally
> an userspace header. For now, we just copy this header in an userspace
> application.
> 
> Signed-off-by: Alexander Aring <alex.aring@xxxxxxxxx>
> ---
> The "int addr_type" should be the above enum. I will fix this later. This
> header has also other various issues. For now I just want the same version
> in userspace which is also inside kernelspace.
> 
> include/net/af_ieee802154.h | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/include/net/af_ieee802154.h b/include/net/af_ieee802154.h
> index 7d38e2f..63af3f2 100644
> --- a/include/net/af_ieee802154.h
> +++ b/include/net/af_ieee802154.h
> @@ -21,6 +21,7 @@
> #define _AF_IEEE802154_H
> 
> #include <linux/socket.h> /* for sa_family_t */
> +#include <linux/types.h>
> 
> enum {
> 	IEEE802154_ADDR_NONE = 0x0,
> @@ -34,10 +35,10 @@ enum {
> 
> struct ieee802154_addr_sa {
> 	int addr_type;
> -	u16 pan_id;
> +	__u16 pan_id;
> 	union {
> -		u8 hwaddr[IEEE802154_ADDR_LEN];
> -		u16 short_addr;
> +		__u8 hwaddr[IEEE802154_ADDR_LEN];
> +		__u16 short_addr;
> 	};
> };

which address information is this? Are these the socket addresses you use for bind(), connect() etc.

In that case shouldn't this be sa_family_t instead.

Regards

Marcel

--
To unsubscribe from this list: send the line "unsubscribe linux-wpan" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux