Hi, On Fri, Nov 21, 2014 at 09:35:21PM +0530, Varka Bhadram wrote: > Hi, > > There are two header_ops operations defined for mac802154 at [1]. One is for creating header another for parsing. > > Creation of mac802154_header_create() happening at [2] by using dev_hard_header(), but i did not find dev_parse_header() > for header parse by mac802154_header_parse(). > > Am i missing anything.? > Parsing frames are completely done at [0]. With call of "netif_receive_skb(skb);" the frame is deliverd into packet layer. Currently there exist several issues with parsing frames which I don't will explain now. Now the header_ops structure: These callbacks are many used by arp or ndisc. For me there exist no reason why a wpan interface implements such functionallity. The lowpan interface needs these callbacks. For the rework I removed dev_hard_header calls for 802154 upper layers. Not for the lowpan interface. What we now doing inside the 802154 layer is to use dev_hard_header and pass additional parameters over skb->cb, but we don't need that for the wpan interface. At lowpan interface the ndisc IPv6 cache will tell us the destination address, that's why need this there. For af802154: this is currently a complete weird implementation. For more documentation about that the header_ops callback structure does, read the implementation for ethernet. [1] Sorry I am busy right now and it's also not easy to doing some new mechanism into the frame parsing/mac header generation because it's used everywhere. - Alex [0] http://git.kernel.org/cgit/linux/kernel/git/bluetooth/bluetooth-next.git/tree/net/mac802154/rx.c?id=24ccb9f4f7a3a5a867bbc880019cdb4b41176b63#n196 [1] http://lxr.free-electrons.com/source/net/ethernet/eth.c#L345 -- To unsubscribe from this list: send the line "unsubscribe linux-wpan" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
