Re: problems with udp header compression

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



I will send a patch. I have done lots of testing and it seems fine.
Do you want the patch based on bluetooth-next?

Simon

On 01/11/14 09:10, Alexander Aring wrote:
Hi Simon,

On Thu, Oct 30, 2014 at 10:18:35AM +0000, Simon Vincent wrote:
This appears to be because if you use a RAW socket with IPPROTO_RAW the ipv6
stack passes it straight through and the skb transport_header,
network_header offset are not set.

Putting the following at the top of compress_udp_header fixes the problem
but I am not sure it is safe.
if (skb->transport_header == skb->network_header){
         skb_set_transport_header(skb,sizeof(struct ipv6hdr));
     }

I see, this could make trouble for IPV6 RAW sockets. Can you please send
a patch for this and cc linux-bluetooth and linux-wpan. Also add some
comment why we do this is here, because the RAW socket issue.

Or just send it as RFC (means replace the PATCH into RFC in the
subject). Then we can talk about a better solution if this isn't a
perfect solution.

Also remove the unnecessary brackets -> checkpatch should show an error
because this.

- Alex
--
To unsubscribe from this list: send the line "unsubscribe linux-wpan" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-wpan" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux