On 10/29/2014 10:52 AM, Alexander Aring wrote:
- sdata->local->phy->current_page != sdata->page) { - mutex_unlock(&sdata->local->phy->pib_lock); - - work = kzalloc(sizeof(*work), GFP_ATOMIC); - if (!work) - return; - - INIT_WORK(&work->work, phy_chan_notify); - work->dev = dev; - queue_work(sdata->local->workqueue, &work->work); + res = drv_set_channel(local, page, chan); + if (res) { + pr_debug("set_channel failed\n");Why don't we use netdev_dbg() here...?} else {because there comming more patches and I am not at the finally cleanup. This code will be part of the deprecated netlink interface. I don't want to fix anything here. It should only work for the things which we support in the official userspace software and that is. Channel setting, interface add/del and setting address filter. I don't want to send a patch series which contains more than 20 patches. This patch I could also add an another patch for removing the worker here and I really don't have an idea why we have a worker here. This channel setting patch is more a rework. In further all phy settings are directly calls to the driver. MAC settings are stored at each interface and setted by a open/close or rather ifup and ifdown.
I think when we do ifup the open function will be called..?
There will come a new netlink interface which use the framework like wireless. The old one will also be functional but we will remove it some or later.
What is the New netlink interface..? I would like to know. -- Thanks and Regards, Varka Bhadram. -- To unsubscribe from this list: send the line "unsubscribe linux-wpan" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
