Hi Alex,
I've prepared the patches for freeing skb outside of the decompress
routines but now I'm unsure whether this is the best thing to do.
Plus side
it makes the decompression routine neater, no goto's, just return an
error code.
Centralises the freeing of the skb.
Easier to maintain, future decompression routines don't have to worry
about making sure all error paths have freed the skb.
Negative side
Decompression routines musn't reallocate the skb, ie make a copy. The
skb pointer that is passed in must still be valid on return otherwise we
get a double free. I think skb_cow is ok as it calls pskb_expand_head
which just makes more room in the data but if a routine was to use
skb_copy then I think we would be in trouble.
Maybe decompression routines should only be using routines like skb_cow
as they are more effecient. What are your thoughts before I send the
series?
- Martin.
--
To unsubscribe from this list: send the line "unsubscribe linux-wpan" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
