Re: [PATCH linux-wpan v3] ieee802154: 6lowpan: ensure header compression does not corrupt ipv6 header

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Sep 22, 2014 at 11:58:17AM +0200, Alexander Aring wrote:
> Hi Simon,
> 
> So last but not least, I run checkpatch on it, you should always run
> checkpatch before sending patches. And also pass the argument "--strict"
> on checkpatch.
> 
> Example:
> ./scripts/checkpatch.pl --strict 0001-ieee802154-6lowpan-ensure-header-compression-does-no.patch
> 
> ERROR: trailing whitespace
> #119: FILE: net/ieee802154/6lowpan_rtnl.c:135:
> +^Imemcpy(&info->daddr.u.extended_addr, daddr, $
> 
> CHECK: Alignment should match open parenthesis
> #120: FILE: net/ieee802154/6lowpan_rtnl.c:136:
> +	memcpy(&info->daddr.u.extended_addr, daddr, 
> +		sizeof(info->daddr.u.extended_addr));
> 
> ERROR: trailing whitespace
> #122: FILE: net/ieee802154/6lowpan_rtnl.c:138:
> +^Imemcpy(&info->saddr.u.extended_addr, saddr, $
> 
> CHECK: Alignment should match open parenthesis
> #123: FILE: net/ieee802154/6lowpan_rtnl.c:139:
> +	memcpy(&info->saddr.u.extended_addr, saddr, 
> +		sizeof(info->daddr.u.extended_addr));
> 

and again sorry. Maybe I have this in my local rework branch but I do
hacking there and doesn't care about whitespace. Only at end of the
rework for creating "real mainline patches", I will care about that.

I hope you understand that. Sorry! :-)

- Alex
--
To unsubscribe from this list: send the line "unsubscribe linux-wpan" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux