Hi Walter,
I would really prefer if you keep the CC list in tact and start using the reply-all button. Also my preference is that people do not top-post on mailing lists.
> I did read through the submittingpatches document, and through the
> coding style document. I must have not understood them.
>
> For my benefit, could you forward me an email that shows how a good
> patch submission looks like?
>
> Regarding the style document, I cleaned up what I could see as being not
> conformant (spaces, curly braces), and I don't know what other
> violations I made.
My advise is to use git-format-patch and git-send-email. That makes sure that a lot of details are just done right. And of course git-log has plenty of examples on how other people are writing commit messages.
And the scripts/checkpatch.pl --strict is really what you want. I have not run the script, but I could spot obvious coding style mistakes from a mile away. Either you did it wrong or you mail client is messing up your email. Either way you need to get that fixed.
' might be better as '"Walter J. Mack" <wmack@xxxxxxxxxxxxxxx>
#45:
Signed-off-by: Walter J. Mack<wmack@xxxxxxxxxxxxxxx>
ERROR: patch seems to be corrupt (line wrapped?)
#57: FILE: drivers/net/ieee802154/mrf24j40.c:27:
ERROR: DOS line endings
#58: FILE: drivers/net/ieee802154/mrf24j40.c:28:
+static bool ext_rx_tx = false ;^M$
ERROR: do not initialise statics to 0 or NULL
#58: FILE: drivers/net/ieee802154/mrf24j40.c:28:
+static bool ext_rx_tx = false ;
WARNING: space prohibited before semicolon
#58: FILE: drivers/net/ieee802154/mrf24j40.c:28:
+static bool ext_rx_tx = false ;
ERROR: DOS line endings
#59: FILE: drivers/net/ieee802154/mrf24j40.c:29:
+module_param(ext_rx_tx, bool, 0444);^M$
ERROR: trailing whitespace
#60: FILE: drivers/net/ieee802154/mrf24j40.c:30:
+MODULE_PARM_DESC(ext_rx_tx, "turn on statemachine to manage external ^M$
ERROR: trailing whitespace
#62: FILE: drivers/net/ieee802154/mrf24j40.c:31:
+^M$
ERROR: trailing whitespace
#70: FILE: drivers/net/ieee802154/mrf24j40.c:70:
+#define REG_TESTMODE 0x22f /* test mode and state machine control ^M$
ERROR: trailing whitespace
#72: FILE: drivers/net/ieee802154/mrf24j40.c:71:
+^M$
ERROR: DOS line endings
#80: FILE: drivers/net/ieee802154/mrf24j40.c:686:
+ if (ext_rx_tx){^M$
WARNING: please, no spaces at the start of a line
#80: FILE: drivers/net/ieee802154/mrf24j40.c:686:
+ if (ext_rx_tx){^M$
WARNING: suspect code indent for conditional statements (4, 6)
#80: FILE: drivers/net/ieee802154/mrf24j40.c:686:
+ if (ext_rx_tx){
+ ret = write_long_reg(devrec, REG_TESTMODE, 0x0f);
ERROR: space required before the open brace '{'
#80: FILE: drivers/net/ieee802154/mrf24j40.c:686:
+ if (ext_rx_tx){
ERROR: DOS line endings
#81: FILE: drivers/net/ieee802154/mrf24j40.c:687:
+ ret = write_long_reg(devrec, REG_TESTMODE, 0x0f);^M$
WARNING: please, no spaces at the start of a line
#81: FILE: drivers/net/ieee802154/mrf24j40.c:687:
+ ret = write_long_reg(devrec, REG_TESTMODE, 0x0f);^M$
ERROR: DOS line endings
#82: FILE: drivers/net/ieee802154/mrf24j40.c:688:
+ if (ret)^M$
WARNING: please, no spaces at the start of a line
#82: FILE: drivers/net/ieee802154/mrf24j40.c:688:
+ if (ret)^M$
ERROR: DOS line endings
#83: FILE: drivers/net/ieee802154/mrf24j40.c:689:
+ goto err_ret;^M$
ERROR: code indent should use tabs where possible
#83: FILE: drivers/net/ieee802154/mrf24j40.c:689:
+ goto err_ret;^M$
WARNING: please, no spaces at the start of a line
#83: FILE: drivers/net/ieee802154/mrf24j40.c:689:
+ goto err_ret;^M$
ERROR: DOS line endings
#84: FILE: drivers/net/ieee802154/mrf24j40.c:690:
+ }^M$
WARNING: please, no spaces at the start of a line
#84: FILE: drivers/net/ieee802154/mrf24j40.c:690:
+ }^M$
ERROR: DOS line endings
#85: FILE: drivers/net/ieee802154/mrf24j40.c:691:
+^M$
ERROR: DOS line endings
#86: FILE: drivers/net/ieee802154/mrf24j40.c:692:
+^M$
CHECK: Please don't use multiple blank lines
#86: FILE: drivers/net/ieee802154/mrf24j40.c:692:
+
+
total: 17 errors, 8 warnings, 1 checks, 39 lines checked
NOTE: whitespace errors detected, you may wish to use scripts/cleanpatch or
scripts/cleanfile
Regards
Marcel
--
To unsubscribe from this list: send the line "unsubscribe linux-wpan" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
