Hi,
On Wed, Aug 13, 2014 at 03:46:32PM +0200, Alexander Aring wrote:
> The slave_open function is only called by ndo_open callback. This
> callback is already protected to do a ip link set wpan0 up twice.
> This patch removing also a unnecessary for each loop to find the right
> entry which is already known.
>
> Signed-off-by: Alexander Aring <alex.aring@xxxxxxxxx>
> ---
> net/mac802154/iface.c | 13 -------------
> 1 file changed, 13 deletions(-)
>
> diff --git a/net/mac802154/iface.c b/net/mac802154/iface.c
> index ae774d3..ab23246 100644
> --- a/net/mac802154/iface.c
> +++ b/net/mac802154/iface.c
> @@ -35,24 +35,11 @@
> static int mac802154_slave_open(struct net_device *dev)
> {
> struct ieee802154_sub_if_data *sdata = IEEE802154_DEV_TO_SUB_IF(dev);
> - struct ieee802154_sub_if_data *subif;
> struct ieee802154_local *local = sdata->local;
> int res = 0;
>
> ASSERT_RTNL();
>
> - if (sdata->type == NL802154_IFTYPE_NODE) {
> - mutex_lock(&sdata->local->iflist_mtx);
> - list_for_each_entry(subif, &sdata->local->interfaces, list) {
> - if (subif != sdata && subif->type == sdata->type &&
> - subif->running) {
> - mutex_unlock(&sdata->local->iflist_mtx);
> - return -EBUSY;
> - }
> - }
> - mutex_unlock(&sdata->local->iflist_mtx);
> - }
I finally found where it was copy&pasted from wireless code and
obfuscated afterwards. [0]
It's like a good puzzle. :-)
I adapt the current 80211 behaviour.
I will write a status update about the rework process today.
- Alex
[0] http://lxr.free-electrons.com/source/net/mac80211/iface.c?v=3.16#L257
--
To unsubscribe from this list: send the line "unsubscribe linux-wpan" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
