Hi, On Thu, Aug 14, 2014 at 08:37:24AM +0100, Martin Townsend wrote: > Hi Alex, > > Looks good to me. The monitor devices work fine for us on both our wireless and plc interfaces using tcpdump. Out of interest, in what way are they broken? > Okay, in my setup I can't set any channels to the monitor interface. It's only working if I set some channel hardcoded and the remove of the monitor interface is also broken. I gave up to understand how it works. If you see [0] you will see: dev->ml_priv = &mac802154_mlme_reduced; The mac802154_mlme_reduced struct is defined at [1]. It has only the .get_phy = mac802154_get_phy, assign. But mac802154_get_phy has a assertion on: BUG_ON(dev->type != ARPHRD_IEEE802154); Back to [0] you will see: dev->type = ARPHRD_IEEE802154_MONITOR; which doesn't fit together with a BUG_ON(dev->type != ARPHRD_IEEE802154); I never hit this BUG_ON and really doesn't know what's going on there, I want to implement a MONITOR interface like 80211. :-) Nevertheless I gave up to understand what going on there and I can't also set channels. Also removing the monitor interface with iz doesn't work (I think there was some deadlock). A monitor device should be going into the promiscous mode of a device. But we also don't support this. Okay if you device doesn't has a hardware filter, it's like to have a promiscous mode. But sometimes promiscous mode also doesn't care about CRC or something else. A monitor device should also be able to show broken packets. I drop this interface type because it really bypass only the mac802154 stack and nothing else. I don't want to say "we don't need a MONITOR interface type", but this is for my opinion in an not useful state. And really I don't want to insert something mainline which breaks any existing support (monitor, fakelb, crypto, ...). I can't do a deletion of net/mac802154 (ieee802154) and simple add a new one, but deleting of subsubsystems like montior, fakelb and add a rework of this should not make any problems. - Alex [0] http://lxr.free-electrons.com/source/net/mac802154/monitor.c [1] http://lxr.free-electrons.com/source/net/mac802154/mac_cmd.c#L105 [2] http://lxr.free-electrons.com/source/net/mac802154/mac_cmd.c#L80 -- To unsubscribe from this list: send the line "unsubscribe linux-wpan" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
