Search Linux Wireless

Re: [PATCH] cfg80211: Remove unused VHT chan code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 11/29/2012 2:36 PM, Johannes Berg wrote:
On Thu, 2012-11-29 at 10:05 +0100, Johannes Berg wrote:
On Thu, 2012-11-29 at 14:28 +0530, Mahesh Palivela wrote:
On 11/29/2012 02:22 PM, Johannes Berg wrote:
On Thu, 2012-11-29 at 14:11 +0530, Mahesh Palivela wrote:
From: Mahesh Palivela <maheshp@xxxxxxxxxxx>

Cleanup of unused VHT channel config related code.

Huh, good catch, thanks. Applied.

Thanks. Even below also can be removed as cfg80211_chandef_usable()
checks this at the beginning.

         if (!cfg80211_chandef_valid(chandef))
                 return -EINVAL;

Hmm good point I'll roll that in.

No actually it can't, cfg80211_chandef_usable() triggers a warning which
we can't do if userspace just sends invalid information; however it's
doing that for all other in-kernel users intentionally.

ok. So in case of nl80211_parse_chandef() we will be calling cfg80211_chandef_valid() twice.
No problem.


johannes


--
Thanks,
Mahesh
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux