On Wed, 2012-11-28 at 21:12 +0200, Arik Nemtsov wrote: > On Wed, Nov 28, 2012 at 8:25 PM, Luciano Coelho <coelho@xxxxxx> wrote: > > On Wed, 2012-11-28 at 19:46 +0200, Arik Nemtsov wrote: > >> On Wed, Nov 28, 2012 at 4:34 PM, Luciano Coelho <coelho@xxxxxx> wrote: > >> > On Wed, 2012-11-28 at 11:42 +0200, Arik Nemtsov wrote: > >> >> From: Ido Reis <idor@xxxxxx> > >> >> > >> >> update the fw logger mode to continuous, and output to dbgpins (uart). > >> >> > >> >> Signed-off-by: Ido Reis <idor@xxxxxx> > >> >> Signed-off-by: Arik Nemtsov <arik@xxxxxxxxxx> > >> >> --- > >> > > >> > I think for upstream it's best to keep it as it was? Most people won't > >> > have the debug pins and won't want to get them continuously. Sending to > >> > the host and only on demand seems more reasonable to me. > >> > >> I think the default settings should be the ones the dev people are > >> using. For production a customer can (and will) change this via a > >> wlconf file. > > > > I disagree. What goes upstream is not for the developers, but for the > > users. Developers can more easily change the wlconf file (they know > > about it), end-users can just send us what we ask, without having to > > mangle with wlconf. > > I think the users won't know what to do with this anyway without some > guidance from TI during debugging, so this argument is pretty moot > IMHO. Yeah, no use to keep arguing. > I guess we also differ in our point of view about this stuff. When I'm > constantly working with an evolving driver, it helps to have the > default tuned to my needs. Your needs, so keep a patch in your tree. Or, the proper way, fine-tune your wlconf binary file! :) > >> I also know firsthand that the SDIO logger is pretty bad (misses > >> logs). The only way to get decent logging is via the dbg pins. > > > > The dbg pins also miss logs sometimes, when they come too fast. For > > "real life" (ie. mainline) we should assume that most users won't have a > > board with dbg pins exposed. > > > > We can keep this patch in our internal tree. > > I'm for keeping as little stuff as possible in the internal tree. I'm for avoiding patches changing this configuration all the time in the mainline. In fact, this whole hardcoded wlconf struct was not supposed to be there at all (did you notice that the driver prints out an *error* if you don't have a proper wlconf file?). -- Luca. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
