Search Linux Wireless

Re: [PATCH 03/20] wlcore: Allow memory access when the FW crashes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 2012-11-27 at 13:54 +0200, Arik Nemtsov wrote:
> On Tue, Nov 27, 2012 at 11:34 AM, Luciano Coelho <coelho@xxxxxx> wrote:
> > On Tue, 2012-11-27 at 08:44 +0200, Arik Nemtsov wrote:
> >> From: Ido Yariv <ido@xxxxxxxxxx>
> >>
> >> When the no_recovery flag is used, the recovery work will not restart
> >> the FW and the state will not be set to 'on'. To enable post-mortem
> >> analysis, allow memory access in the 'restarting' state.
> >>
> >> Also, since the FW might not be operational, don't fail the read/write
> >> operations if elp_wakeup fails.
> >>
> >> Reported-by: Arkady Miasnikov <a-miasnikov@xxxxxx>
> >> Signed-off-by: Ido Yariv <ido@xxxxxxxxxx>
> >> Signed-off-by: Arik Nemtsov <arik@xxxxxxxxxx>
> >> ---
> >
> > This is weird.  This patch is already in (d5560238) and the one here is
> > actually just part of it and probably won't apply.
> 
> Heh. It seems Eliad and I are to blame (all the rebases can really
> mess with the mind).

Yeah, all these internal rebases suck.


> There's a patch by Eliad to reverse the patch you just mentioned:
> 
> commit fd8e73af670e6b57708eafe927f5d0364018b4e5
> Author: Eliad Peller <eliad@xxxxxxxxxx>
> Date:   Wed Nov 14 02:28:26 2012 +0200
> 
>     wlcore: don't allow access to FW mem when chip is off
> 
> (which I submitted earlier in my part 1 series)
> 
> And the current patch simply cancels it out. So please ignore the
> previous patch as well as this one. Good catch :)

Okay, I'll ignore this one and Eliad's in the previous series.

--
Luca.

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux