On 11/19/2012 09:35 PM, Arend van Spriel wrote: > On 11/15/2012 03:08 PM, Seth Forshee wrote: >> Add a new brcmsmac_msg trace system to enable writing of debug messages >> to the trace buffer, and add brcms_* macros for storing device debug >> messages in the trace buffer in addition to the printk log buffer. > > Reviewed-by: Pieter-Paul Giesberts <pieterpg@xxxxxxxxxxxx> > Reviewed-by: Arend van Spriel <arend@xxxxxxxxxxxx> >> Signed-off-by: Seth Forshee <seth.forshee@xxxxxxxxxxxxx> >> --- >> drivers/net/wireless/brcm80211/brcmsmac/Makefile | 3 +- >> .../brcm80211/brcmsmac/brcms_trace_events.h | 68 >> +++++++++++++++++++- >> drivers/net/wireless/brcm80211/brcmsmac/debug.c | 44 +++++++++++++ >> drivers/net/wireless/brcm80211/brcmsmac/debug.h | 40 ++++++++++++ >> 4 files changed, 151 insertions(+), 4 deletions(-) >> create mode 100644 drivers/net/wireless/brcm80211/brcmsmac/debug.c >> create mode 100644 drivers/net/wireless/brcm80211/brcmsmac/debug.h Hi Seth, Internally, we already had a debug.[ch] as we added some debugfs functionality. I am merging your changes into it, but that means your code will be put under the same permissive license as the other source code, ie. Dual BSD/GPL. So I feel obliged to ask: Are you ok with me doing that and do you want me to add your name in the copyright notice? Gr. AvS -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html