No objections from me Johannes. Please commit. Thanks, Mahesh ________________________________________ From: Johannes Berg [johannes@xxxxxxxxxxxxxxxx] Sent: Tuesday, November 20, 2012 5:51 PM To: Mahesh Palivela Cc: linux-wireless@xxxxxxxxxxxxxxx Subject: Re: [RFC v2 4/8] nl80211/cfg80211: support VHT channel configuration On Tue, 2012-11-20 at 17:29 +0530, Mahesh Palivela wrote: > >>> For loops in both functions seems to be similar. One return false, other > >>> return -EINVAL. Can we remove duplication? > >> > >> True, but they check different flags. I suppose we could have a common > >> function where the checked flags are passed in, I can try that. > > > > I'll add this to the patch: > > > > http://p.sipsolutions.net/24eb25fb98ef2d0b.txt > > > > Looks good to me Johannes. Overall your VHT channel config > implementation done so well. Thanks for reviewing! > Partial regulatory check in nl80211_parse_chandef() has to be modified > to include BW check. I see your TODO comment there. Yes, although I'm not completely sure the bandwidth check ever made sense? We'll need to discuss that. Regardless of that though, I'm tempted to put this into the tree now. As we don't have any drivers (but hwsim) using it, we won't have any regulatory issues without the bandwidth check for now, and then we can base further work on this. Any objections from you? If not I'll repost the whole thing as [PATCH]. johannes -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
