On Tue, Nov 20, 2012 at 10:38 AM, Eliad Peller <eliad@xxxxxxxxxx> wrote:
> On Mon, Nov 19, 2012 at 11:23 PM, Arik Nemtsov <arik@xxxxxxxxxx> wrote:
>> On Mon, Nov 19, 2012 at 6:39 PM, Eliad Peller <eliad@xxxxxxxxxx> wrote:
>>> Add some basic chanctx implementation.
>>>
>>> Only add debug prints, and save the vif's channel/band/type.
>>>
>>> Signed-off-by: Eliad Peller <eliad@xxxxxxxxxx>
>>> ---
>
>>> +static int wlcore_op_assign_vif_chanctx(struct ieee80211_hw *hw,
>>> + struct ieee80211_vif *vif,
>>> + struct ieee80211_chanctx_conf *ctx)
>>> +{
>>> + struct wl1271 *wl = hw->priv;
>>> + struct wl12xx_vif *wlvif = wl12xx_vif_to_data(vif);
>>> + int channel = ieee80211_frequency_to_channel(
>>> + ctx->channel->center_freq);
>>> +
>>> + wl1271_debug(DEBUG_MAC80211,
>>> + "mac80211 assign chanctx (role %d) %d (type %d)",
>>> + wlvif->role_id, channel, ctx->channel_type);
>>> +
>>> + wlcore_tx_work_locked(wl);
>>
>> is this some kind of a lame attempt at a flush? :)
>>
>> why not use flush here if the channel was set - or better yet, flush
>> stuff at wlcore_op_unassign_vif_chanctx, which is currently unused.
>> we'll need the TODO there for the per-vif-flush. once everything is
>> upstreamed (hw queues) it would be pretty trivial to implement.
>>
> ok, you convinced me. i'll do a flush on unassign instead. :)
btw, it's also a bug to call wlcore_tx_work_locked() since you didn't
take the mutex, which is another bug in your patch. you should take
the mutex before changing members of wlvif :)
>
>> also not sure what happened to the rest of the stuff done on channel
>> config - updating the rate_set according to band etc..
>>
> well, actually you have a pending patch to fix it, and i planned
> sending it in the next patchset. but since you already asked about it
> i'll just squash it into this patch (and add your SOB). :)
any form you prefer.
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
