Hi Seth,
On 15.11.2012 15:07, Seth Forshee wrote:
Hi Arend,
As promised, here's the updated patch series for brcmsmac to remove the
tx packet queue, add flow control, and add enhanced debug trace support.
I've broken up the tx rework into multiple patches as you requested.
Most notably I've split out the AMPDU session support into a separate
patch, which should make it easier to review that change. I've done
basic testing of each of the new commits to try and verify that no
obvious regressions are introduced by any of them.
Patch 6 contains the real meat of the tx changes and is still fairly
large. It's going to be difficult to break up this patch any further
though. The most obvious thing to break out at this point would be the
flow control support. However, doing this before removing the tx queue
basically results in throw-away code, and removing it after means that
the commit that removes the tx queue may not work well, potentially
making bisects more difficult. The flow control changes really aren't
that big anyway.
Otherwise the changes are pretty trivial, and functionally the end
result should be identical to v1. I've found that I am still receiving
frames occasionally after stopping a queue so I've kept the headroom in
the tx fifos for now.
Changes since v1:
* Break up the tx path rework as much as possible
* BRCMDBG no longer selects BRCMS_TRACING
* Macro for checking for enabled debug levels has been removed in favor
of open coding the checks
* brcms_debug.[ch] renamed to debug.[ch]
* Debug macros changed to lower-case
* Removed some additional dead code
* A few trivial clean-ups
Thanks,
Seth
Seth Forshee (22):
brcmsmac: Introduce AMPDU sessions for assembling AMPDUs
brcmsmac: Don't weight AMPDU packets in txfifo
brcmsmac: Add helper function for updating txavail count
brcmsmac: Remove unimplemented flow control functions
brcmsmac: Use IEEE 802.11 AC levels for pktq precedence levels
brcmsmac: Remove internal tx queue
brcmsmac: Use correct descriptor count when calculating next rx
descriptor
brcmsmac: Reduce number of entries in tx DMA rings
brcm80211: Allow trace support to be enabled separately from debug
brcm80211: Convert log message levels to debug levels
brcmsmac: Add module parameter for setting the debug level
brcmsmac: Add support for writing debug messages to the trace buffer
brcmsmac: Use debug macros for general error and debug statements
brcmsmac: Add brcms_dbg_mac80211() debug macro
brcmsmac: Add rx and tx debug macros
brcmsmac: Add brcms_dbg_int() debug macro
brcmsmac: Add brcms_dbg_dma() debug macro
brcmsmac: Add brcms_dbg_ht() debug macro
brcmsmac: Improve tx trace and debug support
brcmsmac: Add tracepoint for macintstatus
brcmsmac: Add tracepoint for AMPDU session information
brcmsmac: Remove some noisy and uninformative debug messages
Works perfectly fine on my machine.
02:00.0 Network controller: Broadcom Corporation BCM43224 802.11a/b/g/n
(rev 01)
Tested-by: Daniel Wagner <wagi@xxxxxxxxx>
thanks,
daniel
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
