On Sat, Nov 17, 2012 at 12:59 AM, Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote: > On Fri, 2012-11-16 at 22:47 -0800, Marco Porsch wrote: >> Possibilities of setting and getting mesh default power mode are >> added. > > ditto. > > >> + * @NL80211_MESHCONF_POWER_MODE: default link-specific power save >> mode > > please describe the type of the attribute (u8) > > >> + FILL_IN_MESH_PARAM_IF_SET(tb, cfg, power_mode, >> + mask, NL80211_MESHCONF_POWER_MODE, >> + nla_get_u8); > > Huh, ok, how did this FILL_IN_MESH_PARAM thing ever get here ... sad I > missed that, all of those are *completely* missing range checks. > > Please add them here, and somebody should also follow up with a patch to > fix them on the other attributes. Noted. Thomas -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html