Search Linux Wireless

Re: [PATCH] mac80211: support radiotap vendor namespace RX data

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Johannes Berg <johannes@xxxxxxxxxxxxxxxx> writes:

> From: Johannes Berg <johannes.berg@xxxxxxxxx>
>
> In some cases, in particular for experimentation, it
> can be useful to be able to add vendor namespace data
> to received frames in addition to the normal radiotap
> data.
>
> Allow doing this through mac80211 by adding fields to
> the RX status descriptor that describe the data while
> the data itself is prepended to the frame.
>
> Also add some example code to hwsim, but don't enable
> it because it doesn't use a proper OUI identifier.
>
> Signed-off-by: Johannes Berg <johannes.berg@xxxxxxxxx>

[...]

> @@ -769,6 +773,17 @@ static bool mac80211_hwsim_tx_frame_no_nl(struct ieee80211_hw *hw,
>  				(data->tsf_offset - data2->tsf_offset) +
>  				24 * 8 * 10 / txrate->bitrate);
>  
> +#if 0
> +		memcpy(skb_push(nskb, 8), "ABCDEFGH", 8);
> +		rx_status.vendor_radiotap_bitmap = BIT(0);
> +		rx_status.vendor_radiotap_len = 8;
> +		rx_status.vendor_radiotap_align = 8;
> +		rx_status.vendor_radiotap_oui[0] = 0x00;
> +		rx_status.vendor_radiotap_oui[1] = 0x00;
> +		rx_status.vendor_radiotap_oui[2] = 0x00;
> +		rx_status.vendor_radiotap_subns = 127;
> +#endif

I'm nitpicking (as usual :) but a comment would be nice here, for
example the last sentence from the commit log. Otherwise I'm sure
someone will wonder why the code is not compiled.

-- 
Kalle Valo
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux