Search Linux Wireless

rework on .flush() callback

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Johannes,

The brcmsmac driver still faces a lot of bug reports related to the .flush() callback (see [1] from Dave Jones).

Previously I had looked into this and found that during the flush the .tx callback still gets new frames. So I put ieee80211_stop_queues() in the flush and upon exit call ieee80211_wake_queues(). Due to issues still persisting we went a bit deeper in mac80211.

It turns out that mac80211 stops the netif queues for each interface (except monitor iftype) and not the internal queues during a scan. So it stops the netif queues, calls the flush(), and upon returning to the associated channel it wakes up the netif queues.

The problem here is that in brcmsmac the flush does the ieee80211_wake_queues() call, because that could also wakeup the netif queues. So doing it in the driver seems a bad idea. Any suggestion on how to solve this?

off topic question: boy or girl?

Gr. AvS

[1] http://codemonkey.org.uk/2012/11/09/brcmsmac-bugs/

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux