Search Linux Wireless

Re: [PATCH 00/18] brcmsmac: Tx rework and expanded debug/trace support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 11/14/2012 05:05 PM, Seth Forshee wrote:
Hi Arend,

I've got v2 patches prepped with your request changes, which I'll send
as soon as I'm finished testing. I did have a question about one of your
requests though.

On Sun, Nov 04, 2012 at 09:25:49PM +0100, Seth Forshee wrote:
On Sat, Nov 03, 2012 at 06:56:43PM +0100, Arend van Spriel wrote:
   brcmsmac: Add module parameter for setting the debug level

I would prefer doing this through debugfs.

I mentioned this to you at the wireless summit. If this is moved to
debugfs it will not allow for setting the debug level at module load
time. If we leave it a module parameter it can still be set at runtime
via /sys/module/parameters/brcmsmac/debug, assuming BRCMDBG is enabled.
I currently don't have this change in my v2 patches, but if you still
want it changed to debugfs let me know and I'll take care of it.

Thanks,
Seth

Indeed we discussed it. I do not have a strong preference and having it set during module init has its perks. So you can leave it as it is. I am looking forward to your v2 patches ;-)

Gr. AvS


--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux