On 05/11/12 16:21, Johannes Berg wrote:
On Thu, 2012-11-01 at 09:54 +0200, Victor Goldenshtein wrote:
On 22/10/2012 14:55, Johannes Berg wrote:
2. In __nl80211_set_channel() - to cover the case when the CAC was
initiated on a "preset_chan" (during AP init phase) and the IF was
removed before the AP was even started (local->oper_channel wasn't set yet).
Hmm, I'm not sure I get it. How is "local->oper_channel" (a mac80211
variable) related to this cfg80211 code?
It's not, just saying that its not set at this point.
start_ap() isn't expected to be able to succeed until CAC passed
successfully, but OTOH the channel isn't configured until then?
right, the initial CAC performed before start_ap(), only by setting the
channel with __nl80211_set_channel() + radar detection command.
Hmm. Maybe then the channel should be passed to the radar detection
command instead? That way, it can be passed through, you can allocate a
channel context, etc. Much easier?
I was thinking if putting the radar detection parameter in start_ap() is
an option (and thus removing the explicit radar cmd)? We could defer
`netif_carrier_on()` to be done after the initial radar detection is done.
This way the whole thing would be atomic and channel accounting would be
fine.
-- Pozdrawiam / Best regards, Michal Kazior.
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
