On Tue, Nov 13, 2012 at 05:04:03PM +0200, Victor Goldenshtein wrote: > On 05/11/2012 17:21, Johannes Berg wrote: > >On Thu, 2012-11-01 at 09:54 +0200, Victor Goldenshtein wrote: > >>On 22/10/2012 14:55, Johannes Berg wrote: > >>>>2. In __nl80211_set_channel() - to cover the case when the CAC was > >>>>initiated on a "preset_chan" (during AP init phase) and the IF was > >>>>removed before the AP was even started (local->oper_channel wasn't set yet). > >>> > >>>Hmm, I'm not sure I get it. How is "local->oper_channel" (a mac80211 > >>>variable) related to this cfg80211 code? > >> > >>It's not, just saying that its not set at this point. > >> > >>>start_ap() isn't expected to be able to succeed until CAC passed > >>>successfully, but OTOH the channel isn't configured until then? > >> > >>right, the initial CAC performed before start_ap(), only by setting the > >>channel with __nl80211_set_channel() + radar detection command. > > > >Hmm. Maybe then the channel should be passed to the radar detection > >command instead? That way, it can be passed through, you can allocate a > >channel context, etc. Much easier? > > We already pass the frequency in the radar detection command, the > set channel operation comes during hostapd init flow regardless DFS > implementation. Just for clarification for the API: Is the driver required to (re)set the channel itself in the radar detection command, or do we expect that the channel was already set via __nl80211_set_channel() (or other means) before? This would be important for other DFS modes like IBSS later. Thanks, Simon
Attachment:
signature.asc
Description: Digital signature
