2012/11/13 Larry Finger <Larry.Finger@xxxxxxxxxxxx>: > On 11/12/2012 03:58 PM, Maxim Mikityanskiy wrote: >> >> There are some bug fixes, cleanups and dead code removal for >> drivers/staging/rtl8187se > > > There is a serious problems with your patches. The text in > Documentation/SubmittingPatches says: > > "All changes to the Linux kernel occur in the form of patches, as > generated by diff(1). When creating your patch, make sure to create it > in "unified diff" format, as supplied by the '-u' argument to diff(1). > Also, please use the '-p' argument which shows which C function each > change is in - that makes the resultant diff a lot easier to read. > Patches should be based in the root kernel source directory, > not in any lower subdirectory." > > You satisfied the requirements for -u and -p, but you based then on the > wrong directory. I can use sed to rewrite this version for testing, but > please use the correct base in future versions. > > Larry > > I'm sorry, I'll remake patches with correct base and resend them. Really, you could use "cd drivers/staging/rtl8187se" instead of sed, it might be easier for you. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
